Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2024-05-15T20:28:49Z
Lists: pgsql-hackers
On Wed, May 15, 2024 at 04:07:18PM -0400, Robert Haas wrote: > On Wed, May 15, 2024 at 3:30 PM Nathan Bossart <nathandbossart@gmail.com> wrote: >> This is much cleaner, thanks. The only thing that stands out to me is that >> the "once per release cycle" section should probably say to do an indent >> run after downloading the typedef file. > > How's this? I compared this with my v1, and the only bit of information there that I see missing in v3 is that validation step 4 only applies in the once-per-cycle run (or if you forget to pgindent before committing a patch). This might be why I was struggling to untangle the two types of pgindent runs in my attempt. Perhaps it's worth adding a note to that step about when it is required. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Commits
-
Sync typedefs.list with buildfarm, for real this time.
- 70353e463cd3 17.0 landed
-
Remove unused typedefs
- be5942aee7a0 17.0 landed
-
Remove enum WaitEventExtension
- 110eb4aefbad 17.0 landed
-
Add pgindent typedefs file to CVS.
- 16040575a044 9.0.0 cited