Horton

Re: Dump-restore loosing 'attnotnull' bit for DEFERRABLE PRIMARY KEY column(s).

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Amul Sul <sulamul@gmail.com>, vignesh C <vignesh21@gmail.com>
Date: 2024-05-14T15:11:53Z
Lists: pgsql-hackers 
On 2024-May-14, Robert Haas wrote:

> On Tue, May 14, 2024 at 10:42 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > This had already been committed as 270af6f0df76 (the day before it was
> > sent to the next commitfest).  This commit wasn't included in the
> > reverted set, though, so you still get deferrable PKs from
> > RelationGetIndexList.  I don't think this is necessarily a bad thing,
> > though these don't have any usefulness as things stand (and if we deal
> > with PKs by forcing not-null constraints to be underneath, then we won't
> > need them either).
> 
> So, are you saying this should be marked Committed in the commitfest?

Yeah.  I've done so.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Pero la cosa no es muy grave ..."     (le petit Nicolas -- René Goscinny)

Commits

  1. Revert structural changes to not-null constraints

  2. Admit deferrable PKs into rd_pkindex, but flag them as such

  3. Add the notion of REPLICA IDENTITY for a table.