Re: cataloguing NOT NULL constraints

Alvaro Herrera <alvherre@alvh.no-ip.org>

From: Alvaro Herrera <alvherre@alvh.no-ip.org>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, exclusion@gmail.com, dean.a.rasheed@gmail.com, andrewbille@gmail.com, peter@eisentraut.org, pgsql-hackers@lists.postgresql.org, Justin Pryzby <pryzby@telsasoft.com>

Date: 2024-05-12T14:56:09Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert structural changes to not-null constraints
- 6f8bb7c1e961 17.0 landed
Fix inconsistencies in error messages
- 21ac38f498b3 17.0 landed
Disallow direct change of NO INHERIT of not-null constraints
- d45597f72fe5 17.0 landed
Disallow NO INHERIT not-null constraints on partitioned tables
- 13daa33fa5a6 17.0 landed
Better handle indirect constraint drops
- 0cd711271d42 17.0 cited
Don't try to assign smart names to constraints
- d72d32f52d26 17.0 cited
Fix restore of not-null constraints with inheritance
- d9f686a72ee9 17.0 landed
ATTACH PARTITION: Don't match a PK with a UNIQUE constraint
- cee8db3f680b 17.0 landed
Fix propagating attnotnull in multiple inheritance
- c3709100be73 17.0 landed
Check stack depth in new recursive functions
- b0f7dd915bca 17.0 landed
Move privilege check to the right place
- ac22a9545ca9 17.0 cited
Update information_schema definition for not-null constraints
- 3af721794272 17.0 landed
Fix not-null constraint test
- d0ec2ddbe088 17.0 landed
Disallow changing NO INHERIT status of a not-null constraint
- 9b581c534186 17.0 cited
Catalog not-null constraints
- b0e96f311985 17.0 cited
parallel_schedule: add comment on event_trigger test dependency
- c8e43c22be27 17.0 landed
Revert "Catalog NOT NULL constraints" and fallout
- 9ce04b50e120 16.0 landed
Adjust contrib/sepgsql regression test expected outputs.
- 76c111a7f166 16.0 landed
Fix table name clash in recently introduced test
- 728015a47016 16.0 landed
Catalog NOT NULL constraints
- e056c557aef4 16.0 landed
Change the rules for inherited CHECK constraints to be essentially the same
- cd902b331dc4 8.4.0 cited

Attachments

revert-not-null.patch (text/x-diff) patch

On 2024-May-11, Alvaro Herrera wrote:

> I have found two more problems that [] require some more work to fix,
> so I've decided to cut my losses now and revert the whole.

Here's the revert patch, which I intend to push early tomorrow.

Commits reverted are:
21ac38f498b33f0231842238b83847ec63dfe07b
d45597f72fe53a53f6271d5ba4e7acf8fc9308a1
13daa33fa5a6d340f9be280db14e7b07ed11f92e
0cd711271d42b0888d36f8eda50e1092c2fed4b3
d72d32f52d26c9588256de90b9bc54fe312cee60
d9f686a72ee91f6773e5d2bc52994db8d7157a8e
c3709100be73ad5af7ff536476d4d713bca41b1a
3af7217942722369a6eb7629e0fb1cbbef889a9b
b0f7dd915bca6243f3daf52a81b8d0682a38ee3b
ac22a9545ca906e70a819b54e76de38817c93aaf
d0ec2ddbe088f6da35444fad688a62eae4fbd840
9b581c53418666205938311ef86047aa3c6b741f
b0e96f311985bceba79825214f8e43f65afa653a

with some significant conflict fixes (mostly in the last one).

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"El sentido de las cosas no viene de las cosas, sino de
las inteligencias que las aplican a sus problemas diarios
en busca del progreso." (Ernesto Hernández-Novich)