add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Date: 2024-05-03T17:13:48Z
Lists: pgsql-hackers
Attachments
This is likely small potatoes compared to some of the other pg_upgrade-related improvements I've proposed [0] [1] or plan to propose, but this is easy enough, and I already wrote the patch, so here it is. AFAICT there's no reason to bother syncing these dump files to disk. If someone pulls the plug during pg_upgrade, it's not like you can resume pg_upgrade from where it left off. Also, I think we skipped syncing before v10, anyway, as the --no-sync flag was only added in commit 96a7128, which added the code to sync dump files, too. [0] https://postgr.es/m/20240418041712.GA3441570%40nathanxps13 [1] https://postgr.es/m/20240503025140.GA1227404%40nathanxps13 -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Commits
-
Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.
- 6e16b1e42003 18.0 landed
-
Sync pg_dump and pg_dumpall output
- 96a7128b7b4c 10.0 cited