Re: Improve heapgetpage() performance, overhead from serializable

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>, John Naylor <johncnaylorls@gmail.com>, Zhang Mingli <zmlpostgres@gmail.com>, pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Date: 2024-04-08T05:13:14Z
Lists: pgsql-hackers
Hi,

On 2024-04-08 16:18:21 +1200, David Rowley wrote:
> On Mon, 8 Apr 2024 at 16:08, Andres Freund <andres@anarazel.de> wrote:
> > I think visible would be ok, the serialization checks are IMO about
> > visibility too. But if you'd prefer I'd also be ok with something like
> > page_collect_tuples()?
> 
> That's ok for me.

Cool, pushed that way.

Greetings,

Andres Freund



Commits

  1. Remove references to old function name

  2. Reduce branches in heapgetpage()'s per-tuple loop