Horton

Re: Unchecked strdup leading to segfault in pg_dump

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tristan Partin <tristan@neon.tech>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-20T16:20:26Z
Lists: pgsql-hackers 
On Wed, Dec 20, 2023 at 09:39:55AM -0600, Tristan Partin wrote:
> On Wed Dec 20, 2023 at 8:52 AM CST, Daniel Gustafsson wrote:
>> While looking at something else I noticed that pg_dump performs strdup without
>> checking the returned pointer, which will segfault in hasSuffix() in case of
>> OOM.  The attached, which should be backpatched to 16, changes to using
>> pg_strdup instead which handles it.
> 
> Looks good to me.

+1

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix unchecked return value from strdup