Re: Failure with pgbench and --disable-thread-safety in ~v16
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-04T11:17:37Z
Lists: pgsql-hackers
On 2023-Dec-04, Michael Paquier wrote: > While running some tests for 8984480b545d, I have noticed that the TAP > tests of pgbench fail when ~16 is compiled with > --disable-thread-safety: > [16:51:10.467](0.004s) not ok 227 - working \startpipeline with serializable status (got 1 vs expected 0) So the problem is that we do this: ./pgbench -c4 -j2 -t 10 -n -M prepared -f /home/alvherre/Code/pgsql-build/REL_16_STABLE/src/bin/pgbench/tmp_check/t_001_pgbench_with_server_main_data/001_pgbench_pipeline and get this error: pgbench: error: threads are not supported on this platform; use -j1 So, the fix is just to remove the -j2 in the command line. I'll do that in a jiffy. There's no other test that uses -j, except the one specifically designed to test threads. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ Bob [Floyd] used to say that he was planning to get a Ph.D. by the "green stamp method," namely by saving envelopes addressed to him as 'Dr. Floyd'. After collecting 500 such letters, he mused, a university somewhere in Arizona would probably grant him a degree. (Don Knuth)
Commits
-
Don't use pgbench -j in tests
- be7b4d976600 14.11 landed
- a3f76a3f7e3a 17.0 landed
- 419cac053b6b 16.2 landed
- 25f2a4375644 15.6 landed