Horton

Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amul Sul <sulamul@gmail.com>, pgsql-hackers@postgresql.org
Date: 2023-11-14T16:05:53Z
Lists: pgsql-hackers 
On Tue, Nov 14, 2023 at 10:59:04AM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> On Tue, Nov 14, 2023 at 04:25:24PM +0530, Amul Sul wrote:
>>> Changes looks pretty much straight forward, but patch failed to apply on the
>>> latest master head(b41b1a7f490) at me.
> 
>> Thanks for taking a look.  Would you mind sharing the error(s) you are
>> seeing?  The patch applies fine on cfbot and my machine, and check-world
>> continues to pass.
> 
> It may be a question of the tool used to apply the patch.  IME,
> "patch" is pretty forgiving, "git am" very much less so.

Ah.  I just did a 'git diff > file_name' for this one, so you'd indeed need
to use git-apply instead of git-am.  (I ordinarily use git-format-patch,
but I sometimes use git-diff for trivial or prototype patches.)

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

  1. Retire MemoryContextResetAndDeleteChildren() macro.

  2. Simplify code by getting rid of SPI_push, SPI_pop, SPI_restore_connection.

  3. Redefine MemoryContextReset() as deleting, not resetting, child contexts.

  4. tuplestore_donestoring() isn't needed anymore, but provide a no-op