Horton

Thread

Commits

  1. Fix function name in comment

  1. Wrong function name in pgstatfuncs.c

    Kyotaro Horiguchi <horikyota.ntt@gmail.com> — 2023-11-01T08:23:08Z

    Since pgstatfuncs.c was refactored, the comments for synthesized
function names are significant to find the function body.

I happened to find a misspelling among the function name
comments. "pg_stat_get_mods_since_analyze" should be
"pg_stat_get_mod_since_analyze".

Upon checking the file using a rudimentary script, I found no other
similar mistakes in the same file.

(FWIW, I also feel that these macros might be going a bit too far by
synthesizing even the function names.)

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

  2. Re: Wrong function name in pgstatfuncs.c

    Daniel Gustafsson <daniel@yesql.se> — 2023-11-01T08:37:13Z

    > On 1 Nov 2023, at 09:23, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
> 
> Since pgstatfuncs.c was refactored, the comments for synthesized
> function names are significant to find the function body.
> 
> I happened to find a misspelling among the function name
> comments. "pg_stat_get_mods_since_analyze" should be
> "pg_stat_get_mod_since_analyze".
> 
> Upon checking the file using a rudimentary script, I found no other
> similar mistakes in the same file.

Nice catch, that's indeed a tiny typo, will fix.

--
Daniel Gustafsson