RE: pg_dump not dumping the run_as_owner setting from version 16?

Philip Warner <pjw@rhyme.com.au>

From: Philip Warner <pjw@rhyme.com.au>

To: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2023-10-28T08:54:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Teach pg_dump about the new pg_subscription.subrunasowner option.
- 5ba4cc309095 17.0 landed
- 67738dbf9c92 16.1 landed

Attachments

pg_dump-run_as_owner.patch (application/octet-stream) patch

...patch actually attached this time...

> > I as far as I can tell, pg_dump does not dup the ‘run_as_owner` setting for a subscription.
> > 
> > Should it? Should I submit a patch? It seems pretty trivial to fix if anyone else is working on it.
> 
> Yes, it certainly should.  That is an omission in 482675987b.
> Go ahead and write a fix!

Please find attached a patch for pg_dump to honour the setting of `run_as_owner`; I believe that effective pre-16 behavious was to run as owner, so I have set the flag to ‘t’ for pre-16 versions. Please let me know if you would prefer the opposite.


> > Further to this: it seems that `Alter Subscription X Set(Run_As_Owner=True);`
> > has no influence on the `subrunasowner` column of pg_subscriptions.
> 
> This seems to have been fixed in f062cddafe.

Yes, I can confirm that in the current head `pg_subscriptions` reflects the setting correctly.