Re: Doc: Improve note about copying into postgres_fdw foreign tables in batch
Tatsuo Ishii <ishii@sraoss.co.jp>
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: etsuro.fujita@gmail.com
Cc: pgsql-hackers@lists.postgresql.org, a.lepikhov@postgrespro.ru
Date: 2023-03-22T12:08:53Z
Lists: pgsql-hackers
> On Fri, Feb 17, 2023 at 5:45 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>> Here is a small patch to improve the note, which was added by commit
>> 97da48246 ("Allow batch insertion during COPY into a foreign table."),
>> by adding an explanation about how the actual number of rows
>> postgres_fdw inserts at once is determined in the COPY case, including
>> a limitation that does not apply to the INSERT case.
>
> Does anyone want to comment on this?
> <para>
> - This option also applies when copying into foreign tables.
> + This option also applies when copying into foreign tables. In that case
> + the actual number of rows <filename>postgres_fdw</filename> copies at
> + once is determined in a similar way to in the insert case, but it is
"similar way to in" should be "similar way to", maybe?
> + limited to at most 1000 due to implementation restrictions of the
> + <command>COPY</command> command.
> </para>
> </listitem>
> </varlistentry>
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Commits
-
Doc: Improve description of the "batch_size" option for postgres_fdw.
- 0f0a7183d7d8 16.0 landed
-
Allow batch insertion during COPY into a foreign table.
- 97da48246d34 16.0 cited