Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Karl O. Pinc <kop@karlpinc.com>
From: "Karl O. Pinc" <kop@karlpinc.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Greg Stark <stark@mit.edu>, "Gregory Stark (as CFM)"
<stark.cfm@gmail.com>, "Jonathan S. Katz" <jkatz@postgresql.org>, Daniel
Gustafsson <daniel@yesql.se>, w^3 <pgsql-www@lists.postgresql.org>
Date: 2023-03-15T13:55:21Z
Lists: pgsql-hackers
On Wed, 15 Mar 2023 09:41:27 +0100
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> Actually, the 0001 patch hadn't been fully committed yet ... I had
> only added the CSS tweaks. I have now pushed the addition of the
> tables to the SGML sources, with minor tag changes: I found that with
> the <simplelist> outside of any <para>, the list was too close to the
> next paragraph, which looked a bit ugly. I put the list inside the
> <para> that explains what the list is. It looks good with PDF,
> website-HTML and plain-HTML rendering now; didn't look at other
> output formats. So, the CF entry being marked committed is now
> correct as far as I'm concerned.
Thanks for noticing that. (I'd always vaguely wondered about
lists being inside v.s. outside of paragraphs. There must be other
places in the docs where this matters. ?)
> > There remains an un-committed patch from this thread/commitfest
> > entry:
>
> > diff --git a/doc/src/sgml/stylesheet-fo.xsl
> > b/doc/src/sgml/stylesheet-fo.xsl index 0c4dff92c4..68a46f9e24 100644
> > --- a/doc/src/sgml/stylesheet-fo.xsl
> > +++ b/doc/src/sgml/stylesheet-fo.xsl
>
> > +<!-- Every sect1 in the contrib appendix gets a page break -->
> > +<xsl:template match="id('contrib')/sect1">
> > + <fo:block break-after='page'/>
> > + <xsl:apply-imports/>
> > +</xsl:template>
>
> Yeah, I think this one achieves what I wanted and isn't a maintenance
> burden, but I would like to hear from other CSS people. I guess I
> could just commit it and see what complaints I get (probably none).
FWIW, this patch is not to CSS. It's XSLT and affects only the PDF
generation.
(The patch is a response to your "aside" and remarks regarding a
separate thread, here:
https://www.postgresql.org/message-id/20230118173447.aegjdk3girgkqu2g%40alvherre.pgsql
)
Regards,
Karl <kop@karlpinc.com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
Commits
-
Remove new <para id="contrib-obsolete">.
- 244ab8c00c42 16.0 landed
-
doc/PDF: Add page breaks for <sect1> in contrib appendix
- 30e9f2608adf 16.0 landed
-
doc: Add lists of modules trusted/obsolete
- a0137388cb64 16.0 landed
-
HTML docs: Add padding to table.simplelist for more readable output
- a7e584a7d68a 16.0 landed
-
Describe each contrib module in its SGML section title
- e86c8b728f3c 16.0 landed