Re: Ability to reference other extensions by schema in extension scripts
Sandro Santilli <strk@kbt.io>
From: 'Sandro Santilli' <strk@kbt.io>
To: Regina Obe <lr@pcorp.us>
Cc: 'Tom Lane' <tgl@sss.pgh.pa.us>, "'Gregory Stark (as CFM)'" <stark.cfm@gmail.com>, pgsql-hackers@lists.postgresql.org, 'Regina Obe' <r@pcorp.us>
Date: 2023-03-13T11:59:16Z
Lists: pgsql-hackers
On Sat, Mar 11, 2023 at 03:18:18AM -0500, Regina Obe wrote: > Attached is a revised patch with these changes in place. I've given a try to this patch. It builds and regresses fine. My own tests also worked fine. As long as ext1 was found in the ext2's no_relocate list it could not be relocated, and proper error message is given to user trying it. Nitpicking, there are a few things that are weird to me: 1) I don't get any error/warning if I put an arbitrary string into no_relocate (there's no check to verify the no_relocate is a subset of the requires). 2) An extension can still reference extensions it depends on without putting them in no_relocate. This may be intentional, as some substitutions may not require blocking relocation, but felt inconsistent with the normal @extschema@ which is never replaced unless an extension is marked as non-relocatable. --strk; Libre GIS consultant/developer https://strk.kbt.io/services.html
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Add @extschema:name@ and no_relocate options to extensions.
- 72a5b1fc8804 16.0 landed
-
pkg-config Requires.private entries should be comma-separated
- 4ef1be5a0b67 16.0 cited
-
Fix logic buglets in pg_dump's flagInhAttrs().
- 128dd9f9eca0 16.0 cited