Horton

Thread

Commits

  1. Mark unsafe_tests module as not runnable with installcheck

  1. unsafe_tests module

    Andrew Dunstan <andrew@dunslane.net> — 2023-02-22T11:47:34Z

    Given its nature and purpose as a module we don't want to run against an 
installed instance, shouldn't src/test/modules/unsafe_tests have 
NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

  2. Re: unsafe_tests module

    Andres Freund <andres@anarazel.de> — 2023-03-12T00:12:21Z

    Hi,

On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote:
> Given its nature and purpose as a module we don't want to run against an
> installed instance, shouldn't src/test/modules/unsafe_tests have
> NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?

Seems like a good idea to me.

Greetings,

Andres Freund

  3. Re: unsafe_tests module

    Andrew Dunstan <andrew@dunslane.net> — 2023-03-12T13:06:46Z

    On 2023-03-11 Sa 19:12, Andres Freund wrote:
> Hi,
>
> On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote:
>> Given its nature and purpose as a module we don't want to run against an
>> installed instance, shouldn't src/test/modules/unsafe_tests have
>> NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?
> Seems like a good idea to me.
>

Thanks, done.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com