Re: Exit walsender before confirming remote flush in logical replication

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>

Cc: amit.kapila16@gmail.com, kuroda.hayato@fujitsu.com, smithpb2250@gmail.com, osumi.takamichi@fujitsu.com, pgsql-hackers@postgresql.org, sawada.mshk@gmail.com, michael@paquier.xyz, peter.eisentraut@enterprisedb.com, dilipbalaut@gmail.com

Date: 2023-02-14T01:13:43Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add wal_sender_shutdown_timeout GUC to limit shutdown wait for replication
- a8f45dee9176 19 (unreleased) landed
pg_upgrade: Add --copy option
- 746915c68669 16.0 cited
Prevent possibility of panics during shutdown checkpoint.
- c6c333436491 10.0 cited
Support clean switchover.
- 985bd7d49726 9.4.0 cited

On 2023-02-14 10:05:40 +0900, Kyotaro Horiguchi wrote:
> What do you think about the need for explicitly specifying the
> default?  I'm fine with specifying the default using a single word,
> such as WAIT_FOR_REMOTE_FLUSH.

We obviously shouldn't force the option to be present. Why would we want to
break existing clients unnecessarily?  Without it the behaviour should be
unchanged from today's.