Re: BUG #17777: An assert failed in nodeWindowAgg.c
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, xinwen@stu.scu.edu.cn, pgsql-bugs@lists.postgresql.org
Date: 2023-02-13T00:46:33Z
Lists: pgsql-bugs
Hi, On 2023-02-13 13:31:54 +1300, David Rowley wrote: > On Mon, 13 Feb 2023 at 05:19, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Why is it okay to check only the filter, and not the rest of the > > WindowFunc's subexpressions? The arguments we've just run through > > seem to apply to a subplan in the direct or aggregated arguments > > as well. > > Good point. I had just been thinking in terms of the reported bug to > make sure we inverse transition the same rows we transition. We also > need to make sure the transition value matches in both transition > directions. What about find_compatible_agg()? I don't think there's as severe consequences, but it also doesn't seem right as-is. Greetings, Andres Freund
Commits
-
Disable WindowAgg inverse transitions when subplans are present
- 836c31ba508c 16.0 landed
- a9fa6d79aded 15.3 landed
- 4aa43ba21846 14.8 landed
- 301eb3ee4ecd 13.11 landed
- ac55abd33537 12.15 landed
- 8d2a8581b6d6 11.20 landed