Re: make_ctags: use -I option to ignore pg_node_attr macro
Tatsuo Ishii <ishii@sraoss.co.jp>
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: nagata@sraoss.co.jp
Cc: masao.fujii@oss.nttdata.com, alvherre@alvh.no-ip.org,
pgsql-hackers@postgresql.org
Date: 2023-02-08T00:20:34Z
Lists: pgsql-hackers
>> The patch drops support for "-n" option :-< >> >> Attached is the patch by fixing make_ctags (make_etags is not >> touched). >> >> If Exuberant-type ctags is available, use it (not changed). >> If Exuberant-type ctags is not available, try old ctags (not changed). >> If the old ctags does not support "-e" option, try etags (new). > > I am not sure if this is good way to check if ctags supports "-e" or not. > > + then ctags --version 2>&1 | grep -- -e >/dev/null > > Perhaps, "--help" might be intended rather than "--version" to check > supported options? Yeah, that was my mistake. > Even so, ctags would have other option whose name contains > "-e" than Emacs support, so this check could end in a wrong result. Therefore, > it seems to me that it is better to check immediately if etags is available > in case that we don't have Exuberant-type ctags. That makes sense. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
Commits
-
Fix make_etags breakage on certain platforms.
- af26f28b9fdd 15.4 landed
- ae66716bf3ef 16.0 landed
-
Fix make_etags failure on Mac.
- 87f21d2c6890 16.0 landed
-
Enhance make_ctags and make_etags.
- d1e2a380cb91 16.0 cited