Horton

Re: make_ctags: use -I option to ignore pg_node_attr macro

Tatsuo Ishii <ishii@sraoss.co.jp>

View thread View on postgr.es
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: nagata@sraoss.co.jp, masao.fujii@oss.nttdata.com, alvherre@alvh.no-ip.org, pgsql-hackers@postgresql.org
Date: 2023-02-08T00:49:41Z
Lists: pgsql-hackers

Attachments

>> I am not sure if this is good way to check if ctags supports "-e" or not. 
>> 
>> +	then	ctags --version 2>&1 | grep -- -e >/dev/null
>> 
>> Perhaps, "--help" might be intended rather than "--version" to check
>> supported options?
> 
> Yeah, that was my mistake.
> 
>>  Even so, ctags would have other option whose name contains
>> "-e" than Emacs support, so this check could end in a wrong result.  Therefore,
>> it seems to me that it is better to check immediately if etags is available 
>> in case that we don't have Exuberant-type ctags.
> 
> That makes sense.

Attached is the v2 patch.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

  1. Fix make_etags breakage on certain platforms.

  2. Fix make_etags failure on Mac.

  3. Enhance make_ctags and make_etags.