Re: make_ctags: use -I option to ignore pg_node_attr macro

On Tue, 07 Feb 2023 21:29:04 +0900 (JST)
Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> > Does is make sense to change make_etags as the attached patch does?
> > This allows make_etags to use etags if Exuberant-type ctags is not
> > available. This allows users to use make_etags if hey has either
> > Exuberant-type ctags or etags.
> 
> The patch drops support for "-n" option :-<
> 
> Attached is the patch by fixing make_ctags (make_etags is not
> touched).
> 
> If Exuberant-type ctags is available, use it (not changed).
>   If Exuberant-type ctags is not available, try old ctags (not changed).
>     If the old ctags does not support "-e" option, try etags (new).

I am not sure if this is good way to check if ctags supports "-e" or not. 

+	then	ctags --version 2>&1 | grep -- -e >/dev/null

Perhaps, "--help" might be intended rather than "--version" to check
supported options? Even so, ctags would have other option whose name contains
"-e" than Emacs support, so this check could end in a wrong result.  Therefore,
it seems to me that it is better to check immediately if etags is available 
in case that we don't have Exuberant-type ctags.

Regards,
Yugo Nagata

>       If etags is not available, give up (new).
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS LLC
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp


-- 
Yugo NAGATA <nagata@sraoss.co.jp>