Re: make_ctags: use -I option to ignore pg_node_attr macro
Tatsuo Ishii <ishii@sraoss.co.jp>
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: masao.fujii@oss.nttdata.com
Cc: nagata@sraoss.co.jp, alvherre@alvh.no-ip.org,
pgsql-hackers@postgresql.org
Date: 2023-02-07T07:52:29Z
Lists: pgsql-hackers
> On 2022/10/19 13:25, Tatsuo Ishii wrote: >> Thanks. the v6 patch pushed to master branch. > > Since this commit, make_etags has started failing to generate > tags files with the following error messages, on my MacOS. > > $ src/tools/make_etags > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ctags: > illegal option -- e > usage: ctags [-BFadtuwvx] [-f tagsfile] file ... > sort: No such file or directory > > > In my MacOS, non-Exuberant ctags is installed and doesn't support > -e option. But the commit changed make_etags so that it always > calls ctags with -e option via make_ctags. This seems the cause of > the above failure. > > IS_EXUBERANT="" > ctags --version 2>&1 | grep Exuberant && IS_EXUBERANT="Y" > > make_ctags has the above code and seems to support non-Exuberant > ctags. > If so, we should revert the changes of make_etags by the commit and > make make_etags work with that ctags? Or, we should support > only Exuberant-type ctags (btw, I'm ok with this) and get rid of > something like the above code? Thanks for the report. I will look into this. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
Commits
-
Fix make_etags breakage on certain platforms.
- af26f28b9fdd 15.4 landed
- ae66716bf3ef 16.0 landed
-
Fix make_etags failure on Mac.
- 87f21d2c6890 16.0 landed
-
Enhance make_ctags and make_etags.
- d1e2a380cb91 16.0 cited