Horton

Re: [PATCH] New [relation] option engine

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: vignesh C <vignesh21@gmail.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>, pgsql-hackers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>, Michael Paquier <michael@paquier.xyz>, Amit Langote <amitlangote09@gmail.com>, Ian Lawrence Barwick <barwick@gmail.com>
Date: 2023-02-01T09:04:26Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Tighten test_predtest's input checks, and improve error messages.

  2. Avoid reference to nonexistent array element in ExecInitAgg().

  3. Clean up newlines following left parentheses

Attachments

On 2023-Jan-31, vignesh C wrote:

> On Tue, 3 Jan 2023 at 18:38, vignesh C <vignesh21@gmail.com> wrote:

> > The patch does not apply on top of HEAD as in [1], please post a rebased patch:
> > === Applying patches on top of PostgreSQL commit ID
> > 92957ed98c5c565362ce665266132a7f08f6b0c0 ===
> > === applying patch ./new_options_take_two_v03f.patch
> > patching file src/include/access/reloptions.h
> > Hunk #1 FAILED at 1.
> > 1 out of 4 hunks FAILED -- saving rejects to file
> > src/include/access/reloptions.h.rej
> 
> There has been no updates on this thread for some time, so this has
> been switched as Returned with Feedback. Feel free to open it in the
> next commitfest if you plan to continue on this.

Well, no feedback has been given, so I'm not sure this is a great
outcome.  In the interest of keeping it alive, I've rebased it.  It
turns out that the only conflict is with the 2022 -> 2023 copyright line
update.

I have not reviewed it.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"El que vive para el futuro es un iluso, y el que vive para el pasado,
un imbécil" (Luis Adler, "Los tripulantes de la noche")