Re: Using WaitEventSet in the postmaster

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2023-01-28T01:59:22Z

Lists: pgsql-hackers

Hi,

On 2023-01-28 14:25:38 +1300, Thomas Munro wrote:
> The nearby thread about searching for uses of volatile reminded me: we
> can now drop a bunch of these in postmaster.c.  The patch I originally
> wrote to do that as part of this series somehow morphed into an
> experimental patch to nuke all global variables[1],

Hah.


> but of course we should at least drop the now redundant use of volatile and
> sigatomic_t.  See attached.

+1

Greetings,

Andres Freund

Commits

Remove unneeded volatile qualifiers from postmaster.c.
- 8d2c1913ed3d 16.0 landed
Fix WaitEventSetWait() buffer overrun.
- f1821b58fc8d 16.0 landed
- 8a98523a542f 15.2 landed
- 547e60b8317e 14.7 landed
- c159b0383fa6 13.10 landed
- bf388ab82850 12.14 landed
- 1b40710a8c89 11.19 landed
Refactor DetermineSleepTime() to use milliseconds.
- 5a26c7b310b6 16.0 landed
Use WaitEventSet API for postmaster's event loop.
- 7389aad63666 16.0 landed
Allow parent's WaitEventSets to be freed after fork().
- b5d0f8ec01c0 16.0 landed
Don't leak a signalfd when using latches in the postmaster.
- 1f0019de2fe3 16.0 landed
Add WL_SOCKET_ACCEPT event to WaitEventSet API.
- 30829e52ff1a 16.0 landed
From: Phil Thompson <phil@river-bank.demon.co.uk>
- d5bbe2aca55b 7.1.1 cited