Re: improving user.c error messages

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2023-01-27T00:09:36Z

Lists: pgsql-hackers

Attachments

v3-0001-Improve-user.c-error-messages.patch (text/x-diff)

On Thu, Jan 26, 2023 at 05:41:32PM -0500, Tom Lane wrote:
> Well, it's not a hint.  I think the above is fine for non-password
> cases, but for passwords maybe
> 
> 	ERROR:  permission denied to alter role password
> 	DETAIL:  To change another role's password, you must have CREATEROLE privilege and ADMIN OPTION on role "%s".

Okay.  I used this phrasing in v3.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve several permission-related error messages.
- de4d456b406b 16.0 landed
Integrate superuser check into has_rolreplication()
- 442f8700656b 16.0 landed
Small code simplification
- 3b7cd8c690f2 16.0 landed
Adjust interaction of CREATEROLE with role properties.
- f1358ca52dd7 16.0 landed
Add new GUC reserved_connections.
- 6e2775e4d4e4 16.0 landed
Rename ReservedBackends variable to SuperuserReservedConnections.
- fe00fec1f5d7 16.0 landed
Update docs and error message for superuser_reserved_connections.
- 6c1d5ba48678 16.0 landed
Add new GUC createrole_self_grant.
- e5b8a4c098ad 16.0 cited
Restrict the privileges of CREATEROLE users.
- cf5eb37c5ee0 16.0 cited
Add a SET option to the GRANT command.
- 3d14e171e9e2 16.0 cited