Re: BUG #17753: pg_dump --if-exists bug

Noah Misch <noah@leadboat.com>

From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>, justin@tonic.ai, pgsql-bugs@lists.postgresql.org
Date: 2023-01-21T16:00:12Z
Lists: pgsql-bugs
On Thu, Jan 19, 2023 at 07:09:50PM -0500, Tom Lane wrote:
> I wrote:
> > I think we need to do the attached, more or less.  Also, although the
> > given case seems to be new, we'd probably better back-patch, because
> > I'm not convinced that there aren't other ways to reach this.
> 
> Ah --- we only need to back-patch to v15, because this business of
> possibly having a comment in the dropStmt is new in a7a7be1f2.
> That commit also added the existing exceptions for comments in
> pg_backup_archiver.c ... but it missed the need to have special
> cases for dropStmts too.

Your commit 74739d1 looks good.  Thanks.



Commits

  1. Avoid harmless warning from pg_dump --if-exists mode.