Re: Remove source code display from \df+?
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: Isaac Morland <isaac.morland@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Magnus Hagander <magnus@hagander.net>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2023-01-19T16:30:21Z
Lists: pgsql-hackers
On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote: > On Wed, 18 Jan 2023 at 00:00, Pavel Stehule <pavel.stehule@gmail.com> wrote: > > > út 17. 1. 2023 v 20:29 odesílatel Isaac Morland <isaac.morland@gmail.com> napsal: > > > >> I welcome comments and feedback. Now to try to find something manageable > >> to review. > > > > looks well > > > > you miss update psql documentation > > > > https://www.postgresql.org/docs/current/app-psql.html > > > > If the form \df+ is used, additional information about each function is > > shown, including volatility, parallel safety, owner, security > > classification, access privileges, language, source code and description. > > Thanks, and sorry about that, it just completely slipped my mind. I’ve > attached a revised patch with a slight update of the psql documentation. > > you should to assign your patch to commitfest app > > > > https://commitfest.postgresql.org/ > > I thought I had: https://commitfest.postgresql.org/42/4133/ This is failing tests: http://cfbot.cputube.org/isaac-morland.html It seems like any "make check" would fail .. but did you also try cirrusci from your own github account? ./src/tools/ci/README BTW, I think "ELSE NULL" could be omitted. -- Justin
Commits
-
Show "internal name" not "source code" in psql's \df+ command.
- 3dfae91f7a12 16.0 landed