Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

Karl O. Pinc <kop@karlpinc.com>

From: "Karl O. Pinc" <kop@karlpinc.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-01-19T17:03:53Z
Lists: pgsql-hackers

Attachments

On Thu, 19 Jan 2023 13:35:17 +0100
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> On 2023-Jan-18, Karl O. Pinc wrote:
> 
> > Oops.  Already sent a revised patch that includes starting each
> > module on a new page, for PDF output.  I'll wait to rip that
> > out after review and start a new thread if necessary.

(I have not removed the PDF page breaks from the latest patch.)

> Here's my review in the form of a delta patch.

Love it.

> I didn't find that a thing called "ISN" actually exists.  Is there a
> reference to that?

Maybe.  I came across it somewhere and it seemed useful.  It's
an initialism for International Standard Number.
https://en.wikipedia.org/wiki/International_Standard_Number
It's the same ISN as in the file name, "isn.sgml".

I've frobbed the ISN related text in my response patch.
(And added a line break to btree-gin.)

Attached are 2 patches, a regular and a delta from your v4 review:

contrib_v5-delta.patch.txt
contrib_v5.patch.txt

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Commits

  1. Remove new <para id="contrib-obsolete">.

  2. doc/PDF: Add page breaks for <sect1> in contrib appendix

  3. doc: Add lists of modules trusted/obsolete

  4. HTML docs: Add padding to table.simplelist for more readable output

  5. Describe each contrib module in its SGML section title