Horton

Re: Rethinking the implementation of ts_headline()

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, sebastian.patino-lang@posteo.net
Date: 2023-01-17T08:32:11Z
Lists: pgsql-hackers 
On 2023-Jan-16, Tom Lane wrote:

> I get this with the patch:
> 
>      ts_headline     |     ts_headline     
> ---------------------+---------------------
>  {ipsum} ... {labor} | {ipsum} ... {labor}
> (1 row)
> 
> which is what I'd expect, because it removes the artificial limit on
> cover length that I added in 78e73e875.  So I'm wondering why you got a
> different result.

Indeed, that's what I get now, too, after re-applying the patches.
I find no way to reproduce the bogus result I got yesterday.

Sorry for the noise.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Every machine is a smoke machine if you operate it wrong enough."
https://twitter.com/libseybieda/status/1541673325781196801

Commits

  1. Fix ts_headline() edge cases for empty query and empty search text.

  2. Fix ts_headline() to handle ORs and phrase queries more honestly.

  3. Fix default text search parser's ts_headline code for phrase queries.