Horton

Thread

Commits

  1. doc: Tell about "vcregress taptest" for regression tests on Windows

  1. Doc: vcregress .bat commands list lacks "taptest"

    Yugo Nagata <nagata@sraoss.co.jp> — 2023-09-25T06:32:04Z

    Hi,

I found that "taptest" is missing in vcregress.bat command list in the
documentation when I tested psql and pgbench on Windows. I know there
is a plan to remove MSVC scripts[1], but is it worth adding one line
to the list for now?

[1] https://www.postgresql.org/message-id/flat/ZQzp_VMJcerM1Cs_%40paquier.xyz

I attached a patch for this case.

Regards,
Yugo Nagata

-- 
Yugo NAGATA <nagata@sraoss.co.jp>

  2. Re: Doc: vcregress .bat commands list lacks "taptest"

    Michael Paquier <michael@paquier.xyz> — 2023-09-25T06:58:39Z

    On Mon, Sep 25, 2023 at 03:32:04PM +0900, Yugo NAGATA wrote:
> I found that "taptest" is missing in vcregress.bat command list in the
> documentation when I tested psql and pgbench on Windows. I know there
> is a plan to remove MSVC scripts[1], but is it worth adding one line
> to the list for now?
> 
> [1] https://www.postgresql.org/message-id/flat/ZQzp_VMJcerM1Cs_%40paquier.xyz
> 
> I attached a patch for this case.

Assuming that the MSVC scripts are gone in v17, and assuming that your
suggestion is backpatched, it would still be useful for 5 years until
v16 is EOL'd.  So I would say yes, but with a backpatch.
--
Michael

  3. Re: Doc: vcregress .bat commands list lacks "taptest"

    Daniel Gustafsson <daniel@yesql.se> — 2023-09-25T07:14:48Z

    > On 25 Sep 2023, at 08:58, Michael Paquier <michael@paquier.xyz> wrote:

> I would say yes, but with a backpatch.

Agreed.

--
Daniel Gustafsson

  4. Re: Doc: vcregress .bat commands list lacks "taptest"

    Andrew Dunstan <andrew@dunslane.net> — 2023-09-25T15:07:57Z

    On 2023-09-25 Mo 03:14, Daniel Gustafsson wrote:
>> On 25 Sep 2023, at 08:58, Michael Paquier<michael@paquier.xyz>  wrote:
>> I would say yes, but with a backpatch.
> Agreed.


+1


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

  5. Re: Doc: vcregress .bat commands list lacks "taptest"

    Michael Paquier <michael@paquier.xyz> — 2023-09-25T23:18:01Z

    On Mon, Sep 25, 2023 at 11:07:57AM -0400, Andrew Dunstan wrote:
> +1

Thanks, applied and backpatched then.
--
Michael

  6. Re: Doc: vcregress .bat commands list lacks "taptest"

    Yugo Nagata <nagata@sraoss.co.jp> — 2023-09-26T05:21:45Z

    On Tue, 26 Sep 2023 08:18:01 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> On Mon, Sep 25, 2023 at 11:07:57AM -0400, Andrew Dunstan wrote:
> > +1
> 
> Thanks, applied and backpatched then.

Thank you!

Regards,
Yugo Nagata

> --
> Michael


-- 
Yugo NAGATA <nagata@sraoss.co.jp>