Re: pg_upgrade --check fails to warn about abstime
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tristan Partin <tristan@neon.tech>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-09-20T17:58:07Z
Lists: pgsql-hackers
On 2023-Sep-20, Tristan Partin wrote: > > +/* > > + * check_for_removed_data_type_usage > > + * > > + * similar to the above, but for types that were removed in 12. > > + */ > > +static void > > +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *datatype) > > Seems like you could make this more generic instead of hardcoding version > 12, and then you could use it for any future removed types as well. Yeah, I thought about that, and then closed that with "we can whack it around when we need it". At this point I imagine there's very few other datatypes we can remove from the core server, if any. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)
Commits
-
pg_upgrade: check for types removed in pg12
- fb9ddd0fafea 16.1 landed
- 8845d8597d77 15.5 landed
- 26c291a15243 14.10 landed
- d3946c4f622f 13.13 landed
- af9f6cd1ddfa 12.17 landed
- 2e3dc8c14811 17.0 landed