Re: Wrong usage of pqMsg_Close message code?
Tatsuo Ishii <ishii@sraoss.co.jp>
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: michael@paquier.xyz
Cc: pavel.stehule@gmail.com, aleksander@timescale.com,
pgsql-hackers@lists.postgresql.org
Date: 2023-08-29T01:04:24Z
Lists: pgsql-hackers
> Yeah, both of you are right here. Anyway, it seems to me that there > is a bit more going on in protocol.h. I have noticed two more things > that are incorrect: > - HandleParallelMessage is missing a message for 'P', but I think that > we should have a code for it as well as part of the parallel query > protocol. I did not know this. Why is this not explained in the frontend/backend protocol document? > - PqMsg_Terminate can be sent by the frontend *and* the backend, see > fe-connect.c and parallel.c. However, protocol.h documents it as a > frontend-only code. I do not blame protocol.h because our frontend/backend protocol document also stats that it's a frontend only message. Someone who started to use 'X' in backend should have added that in the documentation. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
Commits
-
Fix misuse of PqMsg_Close.
- 6475e663b3c6 17.0 landed