Re: [PATCH] Add function to_oct
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Kirk Wolak <wolakk@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Eric Radman <ericshane@eradman.com>, pgsql-hackers@postgresql.org
Date: 2023-08-16T14:24:10Z
Lists: pgsql-hackers
Attachments
- v6-0001-add-to_binary-and-to_oct.patch (text/x-diff)
On Wed, Aug 16, 2023 at 10:35:27AM +0700, John Naylor wrote: > ``` > *ptr = '\0'; > > do > ``` > > to > > ``` > *ptr = '\0'; > do > ``` Oh, I misunderstood. I thought you meant that there might be a whitespace change on that line, not the surrounding ones. This is fixed in v6. > Now I'm struggling to understand why each and every instance has its own > nominal buffer, passed down to the implementation. All we care about is the > result -- is there some reason not to confine the buffer declaration to the > general implementation? We can do that if we use a static variable, which is what I've done in v6. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Commits
-
Add to_bin() and to_oct().
- 260a1f18dae8 17.0 landed