Horton

Re: Using defines for protocol characters

Tatsuo Ishii <ishii@sraoss.co.jp>

View thread View on postgr.es
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: nathandbossart@gmail.com
Cc: alvherre@alvh.no-ip.org, davecramer@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, robertmhaas@gmail.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2023-08-15T21:25:09Z
Lists: pgsql-hackers 
> On Tue, Aug 15, 2023 at 02:46:24PM +0900, Tatsuo Ishii wrote:
>> Is it possible to put the new define staff into protocol.h then let
>> pqcomm.h include protocol.h? This makes Pgpool-II and other middle
>> ware/drivers written in C easier to use the defines so that they only
>> include protocol.h to use the defines.
> 
> It is possible, of course, but are there any reasons such programs couldn't
> include pqcomm.h?  It looks relatively inexpensive to me.  That being said,
> I'm fine with the approach you describe if the folks in this thread agree.

Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
what about other middleware?

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Commits

  1. Introduce macros for protocol characters.

  2. Remove configure check for z_streamp