Re: add timing information to pg_upgrade
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-08-01T15:45:54Z
Lists: pgsql-hackers
On Tue, Aug 01, 2023 at 09:46:02AM +0200, Peter Eisentraut wrote:
> On 31.07.23 20:37, Nathan Bossart wrote:
>> - prep_status("Checking for incompatible \"aclitem\" data type in user tables");
>> + prep_status("Checking for \"aclitem\" data type in user tables");
>
> Why these changes? I think this is losing precision about what it's doing.
The message is too long, so there's no space between it and the "ok"
message:
Checking for incompatible "aclitem" data type in user tablesok
Instead of altering the messages, we could bump MESSAGE_WIDTH from 60 to
62 or 64. Do you prefer that approach? (BTW this probably needs to be
back-patched to v16.)
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Commits
-
pg_upgrade: Bump MESSAGE_WIDTH.
- 2e7d15ab69d9 16.0 landed
- 9625845532ae 17.0 landed