Re: [BUG] Crash on pgbench initialization.
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>, "Anton A. Melnikov" <aamelnikov@inbox.ru>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2023-07-25T03:24:11Z
Lists: pgsql-hackers
Hi, On 2023-07-24 09:42:44 -0700, Andres Freund wrote: > > I don't know this code at all, but I hope that this can be solved with > > just Anton's proposed patch. > > Yes, it's just that off-by-one. I need to check if there's a similar bug for > local / temp table buffers though. Doesn't appear that way. We *do* fail if there's only 1 remaining buffer, but we already did before my change (because we also need to pin the fsm). I don't think that's an issue worth worrying about, if all-1 of local buffers are pinned, you're going to have problems. Thanks Anton / Victoria for the report and fix. Pushed. Greetings, Andres Freund
Commits
-
Fix off-by-one in LimitAdditionalPins()
- bd2f46c6559d 16.0 landed
- f3bc5192889f 17.0 landed