Re: [BUG] Crash on pgbench initialization.
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Anton A. Melnikov" <aamelnikov@inbox.ru>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2023-07-24T13:54:33Z
Lists: pgsql-hackers
On 2023-Jul-24, Michael Paquier wrote: > On Sun, Jul 23, 2023 at 11:21:47PM +0300, Anton A. Melnikov wrote: > > After some research, found this happens when the LimitAdditionalPins() returns exactly zero. > > In the current master, this will happen e.g. if shared_buffers = 10MB and max_worker_processes = 40. > > Then the command "pgbench --initialize postgres" will lead to crash. > > See the backtrace attached. > > > > There is a fix in the patch applied. Please take a look on it. > > Nice catch, issue reproduced here so I am adding an open item for now. > (I have not looked at the patch, yet.) Hmm, I see that all this code was added by 31966b151e6a, which makes this Andres' item. I see Michael marked it as such in the open items page, but did not CC Andres, so I'm doing that here now. I don't know this code at all, but I hope that this can be solved with just Anton's proposed patch. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Find a bug in a program, and fix it, and the program will work today. Show the program how to find and fix a bug, and the program will work forever" (Oliver Silfridge)
Commits
-
Fix off-by-one in LimitAdditionalPins()
- bd2f46c6559d 16.0 landed
- f3bc5192889f 17.0 landed