Re: Inefficiency in parallel pg_restore with many tables

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es

From: Nathan Bossart <nathandbossart@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org

Date: 2023-07-18T04:57:01Z

Lists: pgsql-hackers

Attachments

expand_binaryheap_api.patch (text/x-diff) patch

On Sun, Jul 16, 2023 at 08:54:24PM -0700, Nathan Bossart wrote:
> This seems worth a try.  IIUC you are suggesting making binaryheap.c
> frontend-friendly and expanding its API a bit.  If no one has volunteered,
> I could probably hack something together.

I spent some time on the binaryheap changes.  I haven't had a chance to
plug it into the ready_list yet.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

Remove open-coded binary heap in pg_dump_sort.c.
- 559bc1732180 17.0 landed
Convert pg_restore's ready_list to a priority queue.
- 9bfd44bbde42 17.0 landed
Add function for removing arbitrary nodes in binaryheap.
- c103d073819a 17.0 landed
Make binaryheap available to frontend code.
- 5af0263afd7b 17.0 landed