Horton

Re: Meson build updates

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tristan Partin <tristan@neon.tech>
Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers@postgresql.org
Date: 2023-06-29T18:58:45Z
Lists: pgsql-hackers 
Hi,

On 2023-06-29 13:34:42 -0500, Tristan Partin wrote:
> On Thu Jun 29, 2023 at 12:35 PM CDT, Andres Freund wrote:
> > > v5-0012-Make-finding-pkg-config-python3-more-robust.patch
> >
> > The commit message here is clearly outdated (still talking about Python.h
> > check not being required).  Does the remainder actually add any robustness?
> >
> > I'm on board with removing unnecessary .enabled(), but from what I understand
> > we don't gain anything from adding the if python3_inst.found() branch?
> 
> Attached is a more up to date patch, which removes the old part of the
> commit message. I guess robust is in the eye of the beholder. It is
> definitely possible for the installation to not be found (Python.h not
> existing in newer versions of Meson as an example). All my patch would
> do is keep the build from crashing if and only if the installation
> wasn't found.

Ah - I somehow thought .find_installation().dependency() would return a
not-found dependency when the install wasn't located.


> > Attached my version of 0007 and 0011 (with some changes from 0012 and
> > 0015). I'm running a test of those with the extended CI I have in a branch...
> 
> Thanks for the further review. Did you by chance see my other email in
> another branch of this thread[0]?
> 
> [0]: https://www.postgresql.org/message-id/CTBSCT2V1TVP.2AUJVJLNWQVG3@gonk

I had planned to, but somehow forgot. Will reply.

Greetings,

Andres Freund

Commits

  1. meson: Make detection of python more robust

  2. meson: Pass more feature option through to required kwargs

  3. meson: Tie adding C++ support to the llvm Meson option

  4. meson: Fix intl misspelling

  5. meson: Use a better error message in an impossible case

  6. meson: Make some Meson style more consistent with surrounding code

  7. meson: Fix some grammar usage in Meson comments

  8. meson: Mention the correct way to disable readline support

  9. meson: Remove old comment

  10. meson: Use the not_found_dep constant

  11. meson: Attach colon to keyword argument

  12. meson: Use consistent Meson option description formats

  13. meson: Use consistent casing in Meson option descriptions

  14. meson: Remove triple-quoted strings