Re: [PATCH] Missing dep on Catalog.pm in meson rules

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tristan Partin <tristan@neon.tech>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-06-16T21:16:28Z
Lists: pgsql-hackers
Hi,

On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote:
> Unless I'm misunderstanding, this doesn't look terribly feasible to me. You
> can only get at %INC by loading the module, which in many cases will have
> side effects.

I was envisioning using %INC after the use/require block - I don't think our
scripts load additional modules after that point?


> And then you would also need to filter out things loaded that
> are not our artefacts (e.g. Catalog.pm loads File::Compare).

I don't think we would need to filter the output. This would just be for a
build dependency file. I don't see a problem with rerunning genbki.pl et al after
somebody updates File::Compare?

Greetings,

Andres Freund



Commits

  1. meson: Add dependencies to perl modules to various script invocations