Re: add non-option reordering to in-tree getopt_long
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: noah@leadboat.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
Date: 2023-06-16T00:09:59Z
Lists: pgsql-hackers
Attachments
On Thu, Jun 15, 2023 at 02:30:34PM +0900, Kyotaro Horiguchi wrote: > At Wed, 14 Jun 2023 15:46:08 -0700, Nathan Bossart <nathandbossart@gmail.com> wrote in >> Hm. IIUC modifying the argv pointers on AIX will modify the process title, >> which could cause 'ps' to temporarily show duplicate/missing arguments >> during option parsing. That doesn't seem too terrible, but if pointer >> assignments aren't atomic, maybe 'ps' could be sent off to another part of >> memory, which does seem terrible. > > Hmm, the discussion seems to be based on the assumption that argv[0] > can be safely redirected to a different memory location. If that's the > case, we can prpbably rearrange the array, even if there's a small > window where ps might display a confusing command line, right? If that's the extent of the breakage, then it seems alright to me. I've attached a new version of the patch that omits the POSIXLY_CORRECT stuff. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Commits
-
Simplify option handling in pg_ctl.
- 03d1080d8a95 17.0 landed
-
Teach in-tree getopt_long() to move non-options to the end of argv.
- 411b72034300 17.0 landed