Re: Consistent coding for the naming of LR workers
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: smithpb2250@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-06-16T01:43:27Z
Lists: pgsql-hackers
At Thu, 15 Jun 2023 12:42:33 +1000, Peter Smith <smithpb2250@gmail.com> wrote in > It is better to have a *single* point where these worker names are > defined, so then all output uses identical LR worker nomenclature. > > PSA a small patch to modify the code accordingly. This is not intended > to be a functional change - just a code cleanup. > > Thoughts? I generally like this direction when it actually decreases the number of translatable messages without making grepping on the tree excessively difficult. However, in this case, the patch doesn't seems to reduce the translatable messages; instead, it makes grepping difficult. Addition to that, I'm inclined to concur with Alvaro regarding the gramattical aspect. Consequently, I'd prefer to leave these alone. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Fix untranslatable log message assembly
- e1c83e7b964f 17.0 landed
- b4018ecb88a4 16.0 landed