Horton

Re: add non-option reordering to in-tree getopt_long

Noah Misch <noah@leadboat.com>

View thread View on postgr.es
From: Noah Misch <noah@leadboat.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org
Date: 2023-06-14T00:17:37Z
Lists: pgsql-hackers 
On Wed, Jun 14, 2023 at 09:03:22AM +0900, Michael Paquier wrote:
> On Wed, Jun 14, 2023 at 08:52:27AM +0900, Michael Paquier wrote:
> > On Tue, Jun 13, 2023 at 03:36:57PM -0700, Nathan Bossart wrote:
> >> Windows seems to allow rearranging argv, based upon cfbot's results.  I do
> >> not know about AIX.  In any case, C99 explicitly mentions that argv should
> >> be modifiable.
> > 
> > Few people have AIX machines around these days, but looking around it
> > seems like the answer to this question would be no:
> > https://github.com/nodejs/node/pull/10633
> > 
> > Noah, do you have an idea?

No, I don't have specific knowledge about mutating argv on AIX.  PostgreSQL
includes this, which makes some statement about it working:

#elif ... || defined(_AIX) || ...
#define PS_USE_CLOBBER_ARGV

If you have a test program to be run, I can run it on AIX.

Commits

  1. Simplify option handling in pg_ctl.

  2. Teach in-tree getopt_long() to move non-options to the end of argv.