Horton

Re: Possible regression setting GUCs on \connect

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Alexander Korotkov <aekorotkov@gmail.com>, David Steele <david@pgmasters.net>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2023-05-17T16:47:04Z
Lists: pgsql-hackers 
On Wed, May 17, 2023 at 08:08:36AM -0400, Tom Lane wrote:
> Amit Kapila <amit.kapila16@gmail.com> writes:
>> Tom/Nathan, do you have any further suggestions here?
> 
> My recommendation is to revert this feature.  I do not see any
> way that we won't regret it as a poor design.

I agree.  The problem seems worth solving, but I think we ought to consider
a different approach.  Apologies for not chiming in earlier on the original
thread.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

  1. Revert "Add USER SET parameter values for pg_db_role_setting"

  2. Fix wrong construct_array_builtin() call in GUCArrayDelete()

  3. In hstore_plpython, avoid crashing when return value isn't a mapping.

  4. Allow granting SET and ALTER SYSTEM privileges on GUC parameters.