Horton

Thread

Commits

  1. Improve error message for pg_create_subscription.

  1. improve more permissions-related error messages

    Nathan Bossart <nathandbossart@gmail.com> — 2023-05-12T20:37:21Z

    This is intended as a follow-up to de4d456 [0].  I noticed that c3afe8c
introduced another "must have privileges" error message that I think should
be adjusted to use the new style introduced in de4d456.  І've attached a
small patch for this.

While looking around for other such error messages, I found a few dozen
"must be superuser" errors that might be improved with the new style.  If
folks feel this is worthwhile, I'll put together a patch.

[0] https://postgr.es/m/20230126002251.GA1506128%40nathanxps13

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  2. Re: improve more permissions-related error messages

    Tom Lane <tgl@sss.pgh.pa.us> — 2023-05-12T20:43:08Z

    Nathan Bossart <nathandbossart@gmail.com> writes:
> This is intended as a follow-up to de4d456 [0].  I noticed that c3afe8c
> introduced another "must have privileges" error message that I think should
> be adjusted to use the new style introduced in de4d456.  І've attached a
> small patch for this.

+1

> While looking around for other such error messages, I found a few dozen
> "must be superuser" errors that might be improved with the new style.  If
> folks feel this is worthwhile, I'll put together a patch.

The new style is better for cases where we've broken out a predefined role
that has the necessary privilege.  I'm not sure it's worth troubling
with cases that are still just "must be superuser".  It seems like
you'd mostly just be creating work for the translation team.

			regards, tom lane

  3. Re: improve more permissions-related error messages

    Nathan Bossart <nathandbossart@gmail.com> — 2023-05-12T20:46:18Z

    On Fri, May 12, 2023 at 04:43:08PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> While looking around for other such error messages, I found a few dozen
>> "must be superuser" errors that might be improved with the new style.  If
>> folks feel this is worthwhile, I'll put together a patch.
> 
> The new style is better for cases where we've broken out a predefined role
> that has the necessary privilege.  I'm not sure it's worth troubling
> with cases that are still just "must be superuser".  It seems like
> you'd mostly just be creating work for the translation team.

Makes sense, thanks.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com