Horton

Re: Add two missing tests in 035_standby_logical_decoding.pl

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-26T10:27:51Z
Lists: pgsql-hackers 
> diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
> index 6f7f4e5de4..819667d42a 100644
> --- a/src/test/perl/PostgreSQL/Test/Cluster.pm
> +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
> @@ -2644,7 +2644,16 @@ sub wait_for_catchup
>  	}
>  	if (!defined($target_lsn))
>  	{
> -		$target_lsn = $self->lsn('write');
> +		my $isrecovery = $self->safe_psql('postgres', "SELECT pg_is_in_recovery()");
> +		chomp($isrecovery);
> +		if ($isrecovery eq 't')
> +		{
> +			$target_lsn = $self->lsn('replay');
> +		}
> +		else
> +		{
> +			$target_lsn = $self->lsn('write');
> +		}

Please modify the function's documentation to account for this code change.


-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Porque Kim no hacía nada, pero, eso sí,
con extraordinario éxito" ("Kim", Kipling)

Commits

  1. Fix the race condition in the test case added by commit a6e04b1d20.

  2. Test that invalidated logical slots doesn't retain WAL.

  3. Add a test to verify that subscription to the standby works.

  4. Reduce the log level in 035_standby_logical_decoding.pl.