Re: BUG #17903: There is a bug in the KeepLogSeg()

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: nathandbossart@gmail.com
Cc: zhjwpku@gmail.com, xu.xw2008@163.com, pgsql-bugs@lists.postgresql.org
Date: 2023-04-25T04:14:52Z
Lists: pgsql-bugs
At Mon, 24 Apr 2023 12:14:52 -0700, Nathan Bossart <nathandbossart@gmail.com> wrote in 
> Here is a new version of the patch.  It is fundamentally the same as v2,
> but I've adjusted the comment and commit message a bit.  Barring
> objections, I am planning to commit this (and back-patch to v13) in the
> near future.

> When determining the oldest segment that must be kept for
> replication slots, KeepLogSeg() might calculate a segment number
> ahead of the one for the LSN given to the function.  This causes

Maybe the KeepLogSeg() is a mistake of
XLogGetReplicationSlotMinimumLSN()?

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



Commits

  1. Prevent underflow in KeepLogSeg().