seemingly useless #include recently added
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2023-04-25T02:57:48Z
Lists: pgsql-hackers
Attachments
- 0001-Remove-unnecessary-include.patch (text/x-patch)
Hello. While working on a patch, I noticed that a rcent commit (d4e71df6d75) added an apparently unnecessary inclusion of guc.h in smgr.h. The only change made by the commit to the file is the added #include directive, which doesn't seem to be functioning, and the build actually suceeds without it. Moreover, it brings in some server-related stuff when I incluce smgr.h in storage_xlog.h, causing compilation issues for pg_rewind. Should we remove it? Please find the attached patch. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Remove bogus #include added by d4e71df6d75.
- 828e93a6f2db 16.0 landed