Horton

Re: fairywren hung in pg_basebackup tests

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-07-25T15:35:12Z
Lists: pgsql-hackers 
Noah Misch <noah@leadboat.com> writes:
> On Mon, Jul 25, 2022 at 09:44:21AM -0400, Andrew Dunstan wrote:
>> Perhaps we should have a guard in system_or_bail() and/or system_log()
>> which bails if some element of @_ is undefined.

+1, seeing how hard this is to diagnose.

> That would be reasonable.  Also reasonable to impose some long timeout, maybe
> 10x or 100x PG_TEST_TIMEOUT_DEFAULT, on calls to those functions.

Why would it need to be more than PG_TEST_TIMEOUT_DEFAULT?

			regards, tom lane

Commits

  1. Fix get_dirent_type() for symlinks on MinGW/MSYS.