Horton

Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, pgsql-hackers@postgresql.org, David Rowley <dgrowleyml@gmail.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: 2022-12-29T00:02:23Z
Lists: pgsql-hackers 
On 2022-12-28 13:43:27 -0500, Tom Lane wrote:
> > In the compiler test, I chose to not check whether -Werror=unknown-pragmas is
> > supported - it appears to be an old gcc flag, and the worst outcome is that
> > HAVE_PRAGMA_SYSTEM_HEADER isn't defined.
> > We could alternatively define HAVE_PRAGMA_SYSTEM_HEADER or such based on
> > __GNUC__ being defined.
> 
> Hmm ... I guess the buildfarm would tell us whether that detection works
> correctly on platforms where it matters.  Let's keep it simple if we
> can.

Quick clarification question: Are you suggesting to use #ifdef __GNUC__, or
that it suffices to use -Werror=unknown-pragmas without a separate configure
check?

Commits

  1. perl: Hide warnings inside perl.h when using gcc compatible compiler