Re: [BUG] Logical replica crash if there was an error in a function.

Hi,

On 2022-11-16 17:52:50 +0300, Anton A. Melnikov wrote:
> Sorry, i didn't fully understand what is required and
> added some functions to the test that spend extra cpu time. But i found
> that it is possible to make a test according to previous remarks by adding
> only a few extra queries to an existent test without any additional syncing.
> 
> Experimentally, i could not observe any significant difference in
> CPU usage due to this test addition.
> The difference in the CPU usage was less than standard error.
> See 100_bugs-CPU-time.txt attached.
> 
> > > Additionally
> > > i've tried to reduce overall number of nodes previously
> > > used in this test in a similar way.
> > 
> > Optimizing existing tests isn't an answer to that.  We could
> > install those optimizations without adding a new test case.
> 
> Oh sure! Here is a separate patch for this optimization:
> https://www.postgresql.org/message-id/eb7aa992-c2d7-6ce7-4942-0c784231a362%40inbox.ru
> On the contrary with previous case in that one the difference in the CPU usage
> during 100_bugs.pl is essential; it decreases approximately by 30%.

This CF entry causes tests to fail on all platforms:
https://cirrus-ci.com/build/5755408111894528

E.g.
https://api.cirrus-ci.com/v1/artifact/task/5298457144459264/testrun/build/testrun/subscription/100_bugs/log/regress_log_100_bugs

#### Begin standard error
psql:<stdin>:1: NOTICE:  dropped replication slot "sub1" on publisher
#### End standard error
timed out waiting for match: ERROR:  relation "error_name" does not exist at character at /tmp/cirrus-ci-build/src/test/subscription/t/100_bugs.pl line 115.

Greetings,

Andres Freund