Horton

Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Hamid Akhtar <hamid.akhtar@percona.com>
Cc: Naeem Akhter <naeem.akhter@percona.com>, pgsql-hackers@lists.postgresql.org, Hamid Akhtar <hamid.quddus@enterprisedb.com>
Date: 2022-12-06T23:16:39Z
Lists: pgsql-hackers 
Hi,

On 2022-11-25 02:45:01 +0500, Hamid Akhtar wrote:
> Rebasing the patch to the tip of the master branch.

This doesn't pass tests on cfbot. Looks like possibly some files are missing?

https://api.cirrus-ci.com/v1/artifact/task/4916614353649664/testrun/build/testrun/pageinspect/regress/regression.diffs

diff -U3 /tmp/cirrus-ci-build/contrib/pageinspect/expected/page.out /tmp/cirrus-ci-build/build/testrun/pageinspect/regress/results/page.out
--- /tmp/cirrus-ci-build/contrib/pageinspect/expected/page.out	2022-12-06 20:07:47.691479000 +0000
+++ /tmp/cirrus-ci-build/build/testrun/pageinspect/regress/results/page.out	2022-12-06 20:11:42.955606000 +0000
@@ -1,4 +1,5 @@
 CREATE EXTENSION pageinspect;
+ERROR:  extension "pageinspect" has no installation script nor update path for version "1.12"
 -- Use a temp table so that effects of VACUUM are predictable
 CREATE TEMP TABLE test1 (a int, b int);
 INSERT INTO test1 VALUES (16777217, 131584);
@@ -6,236 +7,203 @@

Greetings,

Andres Freund

Commits

  1. Add bt_multi_page_stats() function to contrib/pageinspect.